Second password recovery bug

[sapphirecat]

I apologize if there's been a release since 1.4.1 which fixes this--1.4.1 was the last one I noticed was out.

admin/index.php line 87 reads:
if(sql_query($query))
That should be "mysql_query" instead! Otherwise there's a database error with no error message, and I guess nothing happens.

I worked around it by uploading a modified admin/index.php that didn't require the correct password, logged in, set a new password, and put the original (but fixed) PHP back.

[raminia]

thanks!!

sql_query is a defined function in includes/functions.php but it should be used as it was there. Thank you for bug report.

[sapphirecat]

So the correct fix is to keep sql_query() as such, and instead throw out the if(...) around it and the else { ... } block? Because sql_query() is already killing us on failure and not returning anything to test?

[raminia]

the solution is as you mentioned. sql_query function is for somewhere else.