Return to site link not working after comment, v1.4.2

[ibejo]

Anyone experiencing an issue where the "return to site" link presented after a comment is entered returns the user to a blank page?

[bretzelman]

yes it seems that it doesn't work very well.

the url given is: pixelpostadress/index.php?popup=comment&showimage=x
instead of: pixelpostadress/index.php?&showimage=x

[steff]

yes, me too

[Connie]

but it's not changed...

I will have a look but I will be away until wednesday...

[ibejo]

It's the addition of the "popup=comment&" that seems to be causing the problem.

[ibejo]

Any movement on this one? It's still a problem.

Thanks!

www.colorblindphotography.com

[Connie]

no movement because today is thursday and I had no time as I mentioned before

[Connie]

this is fixed now and will be fixed in the next version for sure
for those, who do not want to wait, here is the fixed index.php to download:

http://www.bildgier.de/download/indexpp142.zip

please excuse me, it was a stupid logic error, sometimes I can' tell right from left and similar ;=)

[ibejo]

the download is a deadlink? typo?

[Connie]

James, sorry, yes a typo,

try now, it's corrected

[steff]

if it was just a row, could you tell me what you changed? :)

[Connie]

yes, I changed the logic

I know why you ask, you don't want to replace your index.php :lol:
but I will not publish this here as I do not favor any more people hacking the main script by themselves :cry:

I hope you understand that
if you know about PHP you can easily download and compare

[steff]

bah... people who hack their index.php will continue to do that, regardless you write it here or not!

anyway OK, you are the developer :P :)

[Tousiger]

What's againt modifing the main index.php ourselfs ! We're just modifiing to be better, or just to make it better for our template...

Personnally, I had fixed the problem myself, I integrated a 404 error page in template, changed the page greeting the visitor for his comment, etc... I am absolutely open to give the mods... if somebody want's them :P

[Connie]

Tousiger,

I think it is absolutely not necessary that users edit the script just because a lousy developer like me made a mistake!

Just in the moment I read so many postings that people just have no orientation anymore where they should edit something, they mix CSS with template with script...

so, because long time ago, I worked as teacher, I thought it would be better not to encourage people to edit something what they shouldn't at all
I see all these messages (and I remember my first steps) when some ; or ' or \" or " is messed up and these stupid 5xx-errors occur....

that's why

so: the sitution is like this:

in download version 1.4.2 the bug is fixed
in coming version there will never be a problem with redirect to popup-comment or main-index-page-comment because the System-referrer-variable is used to redirect

to encourage creativity, we have the chance to add AddOns to the script and that is where everybody is responsible for himself, unless he publishes something absolutely disturbing ;=(

you got my point? It's just my IMHO and self-protecting, because I spend a lot of time here in the forum and I know about disencouraging newbies (like I was some time ago and still am sometimes)... ;=)

[Tousiger]

What i principally modify in is what i can't achive otherwise... like comment's greeting page template, etc... and i'm triing to devellop an add-on for non-english users... to put the date in any other language... according that you put all months and weekdays in lang-files... why aren't they used... are you workin on this feature... or should i continue search for the light at the end of the tunnel :P

[Connie]

well, the date is always generated by the PHP-date functions

the lang-variables were intended to be used by some browse features, I do not recall anymore in the moment

if we had a language-variable (locale) in the admin-options, it would be very easy to have language-compliant date-formats (combination of locale + php date function)

I put this on the suggestion-list, ok?

[fotogram]

Well, Tousiger...

I guess you ended up breaking your photoblog... All I get is a blank page at http://digitart.coolinc.info/