PDA

View Full Version : Comments popup problem (missing scroll bars) FIX


rich
11-26-2004, 04:44 PM
I found a little problem with the popup comments page. And I have a fix.

I was testing by adding multiple comments, 4-5+. Once the page got longer than the default 540px the popup window would not produce scroll bars.

I tested this on multiple systems and found that Safari was the only browser that had scroll bars without applying the fix below. Firefox for OS X didn’t have scroll bars. In addition, IE and Firefox for windows didn’t have scroll bars either.

Here is the simple fix:
On line 518 of index.php I added scrollbars=yes and it fixed everything.

$tpl = ereg_replace("<COMMENT_POPUP>","<a href='#' onclick=\"window.open('index.php?popup=comment&showimage =$image_id','Comments','scrollbars=yes,width=480,h eight=540');\">$lang_comment_popup</a>",$tpl);

pixelpunk
11-27-2004, 09:57 AM
I thought it defaulted to scrollbars=auto, but there you go.

Thanks, I'll change that.

// punk