PDA

View Full Version : I've lost my links !

phild
10-13-2005, 12:19 AM
I'm building a Pixelpost template, (very loosely based on the meszamis template). I was doing fine, until at some point, all my links on the page do not work anymore —*except for links from thumbnails or image—. The IMAGE_PREVIOUS_LINK as well as the <a href> type links do not work. I can't figure out what I did wrong.

The photoblog is at :
http://www.cassandreraphaelle.com/aventures/index.php?

Running it through the validation web site gives me this error :
Line 7 column 6: end tag for "head" which is not finished.
but I can't see where it's wrong.

In short : I'm stuck and have no idea.
If anyone can help…
phild


And this is the code from image_template.html :

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-type" content="text/html;charset=utf-8" />
<link rel="stylesheet" type="text/css" href="templates/albumcassraph/style.css"/>
</head>
<body>
<!-- go -->
<div id="logo">
</div>

<div id="calendar">
<SITE_CALENDAR>
</div>

<div id="container">
<div id="banner">
<a href="index.php" title="retour page d'accueil">Accueil</a> | <a href="index.php?x=browse">Archives</a> |
<IMAGE_PREVIOUS_LINK> | <a href="index.php">Image du jour</a> | <IMAGE_NEXT_LINK>
</div>
<div id="content">
<div class="shadow"><a href="index.php?showimage=<IMAGE_PREVIOUS_ID>"><img id="image" src="images/<IMAGE_NAME>" alt="<IMAGE_TITLE>" title="Click for <IMAGE_PREVIOUS_TITLE>" /></a></div>
<div class="shadow"><IMAGE_THUMBNAIL_ROW></div>
</div>

<div id="footer"><span class="title"><IMAGE_TITLE> | <COMMENT_POPUP> (<IMAGE_COMMENTS_NUMBER>)</span> &raquo; <IMAGE_NOTES><br /></div>
<p class="pixelpost"><a href="http://www.pixelpunk.se/software/"><img src="http://www.pixelpunk.se/software/service/pixelpost-1.3.png" alt="Pixelpost" border="0" title="pixelpost" /></a></p>
<!-- end --></div>
</body>
</html>
fotogram
10-13-2005, 04:07 AM
I think a complete <head> tag needs to have a <title> tag. Yours does not. Try adding that.
fotogram
10-13-2005, 04:09 AM
<head>
<title>anything</title>
</head>
Connie
10-13-2005, 05:57 AM
the validator says it completely:

head is not complete because title is missing
phild
10-13-2005, 01:59 PM
Thank you fotogram and connie. Adding a title solves the validation issue (connie > the error message on the validator I tried unfortunately wasn't explicit). And puts a nice title on top of the screen.

But I still have problems with the links.

After spending some more hours, I found that the problem comes from adding the logo. If I take this off, the links work again.
<div id="logo"></div>
I did this to include a logo on top of the page, and it refers to the external CSS :
#logo {
background-image: url(images/logo.jpg);
background-repeat: no-repeat;
vertical-align: 0;
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
margin: 0;
padding: 0;
}
I get what I want in terms of design, but how on earth does it disable the links in the rest of the page ???

Thnks for your help !
phild
Connie
10-13-2005, 02:37 PM
Phil,

if you define the doctype as XHTML, you must take care, that standalone-tags (tags, which have no ending tags) are closed not only by > but by />


<img src="http://www.cassandreraphaelle.com/aventures/templates/albumcassraph/images/logo.jpg" height="118" width="488" border="0" >

you did not close the img-tag, that could result in other failures

as you see, the img-tags, which are produced by PP, close correctly

but if you define a style for an object and you don't close this object correctly, these styles are not closed as well ....

try whether the div "Logo" will work, when your logo-image, these beautiful kitschy girls, is closed correctly!

<a href="index.php"><img src="http://www.cassandreraphaelle.com/aventures/templates/albumcassraph/images/logo.jpg" height="118" width="488" border="0" ></a>

this link to index.php is not regarded as valid as the image-tag is not closed correctly and so the </a> is not interpreted

try to correct that and then validate again, it might help, in the moment your page is not valid ...

also <img ... must have alt-tag + title-tag
phild
10-13-2005, 09:53 PM
Thank you Connie for this explaination. I did not know that — you learn by doing, and thanks to such forums and contributors such as you.

The "logo" div still causes problem, but I found a way around it, including the logo image in the image template, and deleting the logo div and associated css. I'm still puzzled because I don't understand what the problem was, but I found a way around it and have already spent too much time on it.

Congratulations to all pixelpost contributors. This is great — nice and straightforward. I've built a couple of wordpress blogs, but it's definitely not suited to photo blogs. Now that I've finished this one for friends of mine, I'll build one for my own photography. I look forward to a PPOTW listing !