View Full Version : Default category auto selected when editing...
12-22-2005, 11:23 AM
I am not sure if this is a known issue / feature but when I am editing an image the default category gets checked on its own even if I had not previously checked it - while this is desirable while uploading new images it is an irritant when editing to keep unchecking the default....
I fixed it by editing the following line if ($firstid == $id ) to if ($firstid == $id AND $_GET['view']<>'images' ) in the function category_list_as_table() in file includes/functions.php
Hope that helps
12-22-2005, 12:03 PM
se.nsuo.us (your nickname is really hard to type)
this is on the list for 1.5 FINAL, thank you that you mention it, it shows how necessary this fix is, which is annoying me as well ;=)
12-22-2005, 12:35 PM
he! he! sensuous - will also do, the nickname is actually the website URL - BTW is there a public CVS repository which can be looked at before shouting wolf!! I mean reporting bugs
12-22-2005, 01:07 PM
yes, sensuous is indeed easier :rolleyes:
well, there is this forum-section "BUG REPORT 1.5" and then the devteam sometimes uses the biological / analogue memory-chip, so-called BRAIN
since I noticed that I had to edit at least 30 images because they had the default category for wrong, I have this on my list and it will definitely be in the bugfixed version! promised!
12-22-2005, 01:47 PM
what happens if nothing is checked at all and you submit the image? like if the user totally forgets?
12-22-2005, 02:23 PM
they die :(
pixelpost users are exploding all over the world
12-22-2005, 02:26 PM
lol...well, i recall that we had default checked by default so something was there by default. I know wordpress and Textpattern do the same thing, sort of.
12-22-2005, 02:28 PM
yep, default should ALWAYS be set if no category is chosen.
but at the moment i'm guessing we just have some sloppy code that sets it to Misc when the page loads instead of checking the link table and only ticking default if no categories have been set.
12-22-2005, 03:38 PM
it is really possible to have images without any category, if you want
nothing bad will happen, just you won't find that image in the archive browsing by category etc....
like it is now it is really annoying
12-22-2005, 08:08 PM
it cant be that annoying, a hidden 'all' category or something would be optimal, but if users forget to change it now, if nothing is selected you will just have tons of images that were forgotten and dont show up in the catergory view...
as far as usabilty, i see it as a circle with no solution, you can gripe with it being checked, but if its annoying to the point that you dont remember about it, how will the other meathod fix the problem?
granted, the code could be set to display an error if no category is selected, but if you always forget, that's annoying too...
12-22-2005, 08:15 PM
maybe i missed something here... but if we're talking about the EDIT images page surely it should just be the categories that were originally chosen by the user to be selected?
12-22-2005, 08:19 PM
yes, indeed we were talking about when edit is clicked, but it seems the topic may have shifted a bit, sorry...
during the edit screen, the users category settings should be present...not the default setup upon upload
03-13-2006, 05:44 AM
I did not read this post before, but we were on this topic already and it was fixed and then got lost ... no problem
the rule should be:
for editing an image, only the categories which are set to this image should be checked
if no categories are set to this post, the default category should be checked
I will download CVS this evening and have a look
thanks GeOs, you did so much in the last time!
IMHO If someone didnt check anything it should stay as it is. Just like checking one doesnt mean that default must be checked.
I would leave it as it is - checking only checked before.
If still think otherwise lets discuss at Dev Team playgorund - Im closing this topic.
vBulletin® v3.7.3, Copyright ©2000-2013, Jelsoft Enterprises Ltd.