PDA

View Full Version : 1.5beta 1 - "continue;" stops showing the rest of the page


eon
12-22-2005, 07:57 PM
In the file functies.php around row 461 you find this script:
if ($menu_name=='')

{

if ('admin_main_menu_contents'==$funcs['workspace'] &

$_GET['view']!=strtolower($funcs['menu_name']) )

continue;
call_user_func ($funcs['function_name'] );

}

I think it must be this script:
if ($menu_name=='')

{

if ('admin_main_menu_contents'==$funcs['workspace'] &

$_GET['view']!=strtolower($funcs['menu_name']) )

call_user_func ($funcs['function_name'] );
continue;

}

Otherwise you will never see the content of raminia's example: admin_newitem.php.

Connie
12-22-2005, 08:00 PM
thank you for the info!
it is a great help!

eon
12-22-2005, 08:13 PM
thank you for the info!
it is a great help!

It was damn hard to find. ;) But it was fun.

GeoS
03-11-2006, 11:05 PM
Sorry for going back to this topic but now Im looking all still existing on CVS not fixed bugs.
I was sitting on this post for a while to get what is going on and as conclusion I can say that oryginal code is OK!

raminia
03-12-2006, 07:33 AM
I remember there was some tricky point there. I must get my noise into it but there was something in that line that was bothering me from the start. I don't know which version is compeletely OK now.

eon
03-12-2006, 04:16 PM
Maybee some one changed it with out let you know?

blinking8s
03-12-2006, 09:48 PM
Maybee some one changed it with out let you know?

always possible...if it's fixed on CVS then it's fixed for future versions, that's all thats super important. That and the worldwide ubiquity of PP 1.5 being used when it is finished....lol

GeoS
03-13-2006, 02:11 AM
I was trying to find in first one part of code some bad points in many tests and I didnt find. For me its OK.
On other hand - second one is buggy.

se.nsuo.us
03-14-2006, 05:00 AM
For better readability of code the code should be reformatted as
if ($menu_name==''){
if ($funcs['workspace']=='admin_main_menu_contents' & $_GET['view']!=strtolower($funcs['menu_name']) ){
continue;
}
call_user_func ($funcs['function_name'] );
} // end if menu is empty


But the code itself is correct - another reason why I don't like if without braces - too confusing to read :)

GeoS
03-14-2006, 04:14 PM
On CVS code now is more obvious.