PDA

View Full Version : no die() at many places


se.nsuo.us
01-12-2006, 04:17 AM
At several places in image_edit.php I see the following statement $result = mysql_query($query) ||("Error: ".mysql_error());

Since there are very few chances of SQL errors happening, no one noticed till now - the statement to be really meaningful should be $result = mysql_query($query) || die ("Error: ".mysql_error());

I suspect this must be true for several other files as well ;)

emil
01-12-2006, 05:44 AM
These where the only ones I found with grep.

admin/images_edit.php: $result = mysql_query($query) ||("Error: ".mysql_error());
admin/images_edit.php: $result = mysql_query($query) ||("Error: ".mysql_error().$admin_lang_imgedit_db_error);
admin/images_edit.php: $result = mysql_query($query) ||("Error: ".mysql_error());
admin/images_edit.php: $result = mysql_query($query) ||("Error: ".mysql_error());

se.nsuo.us
01-12-2006, 06:02 AM
These where the only ones I found with grep.

/me goes and greps again ;)