browse archive - only one page is shown

[Vernon.Trent]

updated to 1.5 final.

http://www.xoverip.info/pb/index.php?x=browse&pagenum=1

when you klick "next" it doesn't show the next page
it had worked before the update.

anyone with the same problem?

[jdleung]

yes, I fixed it. I'll send you later.

[GeoS]

So please tell us where was the problem?

[jdleung]

I had posted the bugs before. but seems no one reply, so I fixed it myself.

[jdleung]

get up
I was going to send you the modified addon, and I found it's been changed a lot in v1.5 pp, so I tried to modified the new one. and then tired and then slept. ;-)

so now I send you the old one that I'm using on my site...
here goes
http://www.jdleungs.com/download/page_archive.zip

[jdleung]

GeoS, here is the problem
when using catgory or date category, clicking the next or previous page link will go to blank.

it's easy to fix this, and myabe stupid way
replace $cat_id = (int)$_GET['category']; with $cat_id = $_GET['category'];

but the date category problem need to add archivedate and monthname to the link.

[Vernon.Trent]

get up
I was going to send you the modified addon, and I found it's been changed a lot in v1.5 pp, so I tried to modified the new one. and then tired and then slept. ;-)

so now I send you the old one that I'm using on my site...
here goes
http://www.jdleungs.com/download/page_archive.zip

thanks for your efforts, but see below.

Forbidden
You don't have permission to access /download/page_archive.zip on this server.

[GeoS]

So repleace it manually. Ill update PP at evening and whole package moment after that.
Thx for bug info.

[jdleung]

Vernon.Trent, it's ok now. I changed the chmod on ftp.

[Vernon.Trent]

@jdleung

ok :) thx

[GeoS]

One thing - just show me the place in this addon's code where $cat_id isnt a INTEGER??

Problem can be only then when it isnt set or is empty. Ill test this case in a minute.

[GeoS]

Fixed in CVS. That was case which I show in my last post - empty category converted to 0.

[jdleung]

GeoS, there is still one more problem about date category. "archivedate" and "monthname" must add to the links.

[GeoS]

What?? I dont get it.

Minute ago I looked to code and it seems to be fine.

PS When you write there is bug please write "little" more about where and how it looks like. Im not magician and cant find everything myself without help from users side.

[jdleung]

when browsing with category, the previous and next link should be like this:
http://www.mysite.com/index.php?x=browse&category=&pagenum=2

and when browsing with date as category, the previous and next link should be like this:
http://www.mysite.com/index.php?x=browse&archivedate=2006-07&monthname=2006-07&pagenum=2

problem is that now the previous and next link is like this:
http://www.mysite.com/index.php?x=browse&category=&pagenum=2

and the page number link is ok.

thanks.

[GeoS]

Fix inside CVS solves all problems.

[jdleung]

thanks.