Comment Popup

[glloeb]

Okay, I really do hate to keep making threads about this, but it would be great if I could get an answer on whats going on. Basically, my site is at least somewhat functional in all browsers, but in Internet Explorer the popup links aren't working. In other words, no new window is created.

The code I'm currently using is this:
<a href="index.php?showimage=<IMAGE_ID>" onclick="window.open('index.php?popup=comment&amp;showimage=<IMAGE_ID>','<IMAGE_TITLE> comments','toolbars=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=no, copyhistory=yes, width=480, height=540');" title="View comments">Comments (<IMAGE_COMMENTS_NUMBER>)</a>

I checked this site (http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp) for the syntax of the window.open method and it should be according to those specifications.

Thanks for your continued help, I really appreciate it,
Gabriel Loeb (http://gabrielloeb.com)
http://gabrielloeb.com

P.S. Special thanks to you GeoS for your help on this.

[GeoS]

Try to put something before window.open:

<a href="index.php?showimage=<IMAGE_ID>" onclick="javascript:window.open('index.php?popup=comment&amp;sh owimage=<IMAGE_ID>','<IMAGE_TITLE> comments','toolbars=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=no, copyhistory=yes, width=480, height=540');" title="View comments">Comments (<IMAGE_COMMENTS_NUMBER>)</a>

PS Nice trick with template file masking ;)

[glloeb]

Okay, I tried your suggestion and while it continues to work in firefox it is not working for me in IE 7 Beta. Sadly, I don't have any other version of IE, so I will leave the change up, perhaps it will work in a non-beta version.

Also, thank you, but I'm not sure I know what template file masking is.

Gabriel Loeb (http://gabrielloeb.com)

[GeoS]

Right now on notebook I also have only IE 7 Beta 2 so I cant say how it works under IE 6 :/

PS Debuger in IE 7 sucks as always :/

[glloeb]

Sorry to bring this back from the dead but I finally got it to work in IE using the <comments_popup> tag; however, I'm wondering where I can edit $lang_comments_popup. Currently it is set to "Comments" but I would like to set it to "Comments (<IMAGE_COMMENTS_NUMBER>)" or "Comments (3)".

Thanks again,
Gabriel Loeb (http://gabrielloeb.com)

P.S. I've searched index.php and can't find where to do this.

[glloeb]

Bleh, nevermind, I got it to work.

[Connie]

Sorry to bring this back from the dead but I finally got it to work in IE using the <comments_popup> tag; however, I'm wondering where I can edit $lang_comments_popup. Currently it is set to "Comments" but I would like to set it to "Comments (<IMAGE_COMMENTS_NUMBER>)" or "Comments (3)".

Thanks again,
Gabriel Loeb (http://gabrielloeb.com)

P.S. I've searched index.php and can't find where to do this.

why you don't check the language file?????????????????