sentinel
12-08-2006, 10:00 AM
don't know if it really is a bug so please move if i'm wrong here
just upgrading to 1.5 from 1.4x and found that a whole bunch of links to commentators pages don't work anymore.
found the preg_match in functions.php line 74 which removes the link if there's no http(s) infront of the comment_url. in 1.5 all url will be extended with an "http://" if it's not entered by the visitor, before inserting it into the db.
this check wasn't there in 1.4 as i can see.
so my questions is..
whats the purpose on removing links without "http(s)://" ?
in terms of back-portability it'd be nice if the comment link in the else case (line 77) would be extended with the "http://" string too and posted aftwards like it is done in line 76.
maybe i didn't catch the reason for unsetting the comment_url?
thx in advance
wfg
\md
just upgrading to 1.5 from 1.4x and found that a whole bunch of links to commentators pages don't work anymore.
found the preg_match in functions.php line 74 which removes the link if there's no http(s) infront of the comment_url. in 1.5 all url will be extended with an "http://" if it's not entered by the visitor, before inserting it into the db.
this check wasn't there in 1.4 as i can see.
so my questions is..
whats the purpose on removing links without "http(s)://" ?
in terms of back-portability it'd be nice if the comment link in the else case (line 77) would be extended with the "http://" string too and posted aftwards like it is done in line 76.
maybe i didn't catch the reason for unsetting the comment_url?
thx in advance
wfg
\md