PDA

View Full Version : deleting images - db problems


sentinel
09-18-2007, 10:12 AM
in pp1.6 (dunno if it still applies to upcoming 1.7 code base) there are 3 missing delete queries
when using the "delete selected" option in the "images" section of the admin panel.

using the "delete" button next to the image (x=delete) removes the corresponding entries from
tags, catassoc and comments table. the "delete selected" option (x=massdelete) _doesn't_.

further massdelete doesn't remove the image and thumbnail files


just a note: you also might think about reordering the delete queries in the single-delete function
as deleting the entry in the pixelpost table prior to the entries in tags,catassoc, comments tables
(which all refer to the id entry of the image in the pixelpost table) might lead to an error
(foreign-key violation) someday.

Dennis
09-18-2007, 06:35 PM
Thanks for pointing this out. We're gonna look into this.

As for the reordering of the queries, we're currently investigating a new approach, more object oriented, which will also change the way queries are handled.

Dennis
09-18-2007, 06:38 PM
I've checked and it was ticket #60 (june 2007)


Image, thumbnail, catagories, comments, and tags are not deleted when using the mass delete function on the edit page.


It has been fixed. But still, thanks for noticing :D

sentinel
09-18-2007, 06:56 PM
d'oh .. sorry :)
(is there a possibility to have a look at the "fixed-list" =) )

Dennis
09-18-2007, 07:27 PM
Yeah that possibility exists, but most comments point to a ticket in Lighthouse. This is a closed system we use for reporting tickets found on the forums, or send to us by mail.

And most comments are like: bug fix, small bug fix, major cleanup and all that stuff. That is because with SVN we can grab the offending code and see all changes made at one point.

As for the lighthouse tickets, I can't export them.