View Single Post
  #3  
Old 11-01-2004, 07:01 PM
Connie
Guest
 
Posts: n/a
Text separation

Hi!

I just scrolled through index.php (version 1.2) and I have 3 major points to show:

1) text entered in the script directly, not via variable from language file

Line 333:
onChange='self.location.href=this.options[this.selectedIndex].value;'><option value=''>$lang_browse_select_category</option><option value='?x=browse&category='>All</option>";

: the word "All"

Line 390:
$tpl = ereg_replace("<COMMENT_POPUP>","<a href='#' onclick=\"window.open('index.php?popup=comment&amp ;amp;showimage=$image_id','Comments','width=480,he ight=540');\">Comments</a>",$tpl);

: the word "Comments"


2) fix dateformat, not via configuration

Line 44:
$datetime = date("Y-m-d H:i:s");

: date format

Line 227:
<br />$comment_name @ $comment_datetime

: should be variable, who likes so long dateformats in the textoutput?

Line 411:
$datetime = date("Y-m-d H:i:s");

: should be a variable date format again

3) fix integrated language file

Line 14:
require("language/lang-english.php");

: should be a variable from administration

greetings,

Connie
Reply With Quote