View Single Post
  #7  
Old 01-29-2009, 10:28 AM
sentinel's Avatar
sentinel Offline
pixelpost guru
 
Join Date: Sep 2005
Posts: 130
yep i see sorry. i just had a look at #327 and was mislead by the error message.

i see two ways to go.

modify the skin
the problem is located in the javascript code where apostrophes
kill the following function in image_template.html
Code:
 
 19 window.onload = function() {
 20      // update title to include image title
 21      document.title = '<IMAGE_TITLE> | ' + document.title;
replace the apostrophes with quotation marks in line 21
Code:
 21      document.title = "<IMAGE_TITLE> | " + document.title;
but this will kill the function again if you ever use quotation marks in your title.

modify the code

and i think this is _not_ the way to go alone to solve the problem.
it's more a general question to the devs

is there reason for the ENT_NOQUOTES option in index.php?
PHP Code:
474  $image_title htmlspecialchars($image_title,ENT_NOQUOTES); 
am i'm missing something? but ENT_QUOTES makes more sense to
me than ENT_NOQUOTES. (as far as i can see, 1.5 used ENT_QUOTES).
especially as $image_title is also used to replace the IMAGE_TITLE tag.

for the images notes you offer IMAGE_NOTES and
IMAGE_NOTES_CLEAN tag (where you could use ENT_QUOTES in line 792 too).

maybe it's possible to offer an according IMAGE_TITLE_CLEAN?
__________________
my pp
good day good light
\martin_d
Reply With Quote