Pixelpost

seriocomic · #1 07-19-2005, 02:07 PM

Hi, I have just downloaded 1.4.1 (and finished upgrading to 1.4.2).

I noticed almost immediately that the feed links and other bits weren't correctly coded (in both the pixelpost-light and pixelpost-dark themes, the new simple theme has no feed linkage):

Code:

&lt;!-- Link for ATOM feed autodiscovery -->
&lt;link rel="service.feed" type="application/x.atom+xml" href="&lt;ATOM_AUTODETECT>" title="&lt;SITE_TITLE>" />
&lt;!-- Link for RSS feed autodiscovery -->
&lt;link rel="alternate" type="application/rss+xml" title="&lt;SITE_TITLE> - RSS feed" href="/index.php?x=rss" />

I may be wrong, but the 'x.' in the media type of the atom link is incorrect and should be removed so it reads 'application/atom+xml'.

The link for the RSS feed seemed to be incorrectly generated as well so I modularized both the ATOM and RSS generation by removing the code segments from the main index.php file and creating addons out of each of them.

I then modified the top portion of code for each module as such:
ATOM:

Code:

$addon_name = "ATOM Module";
$addon_description = "Seperated Atom generation from main index file";
$addon_version = "0.2";
// ################################################//
// ATOM FEED
// ################################################//
$url = $cfgrow['siteurl'];
$atom_url = $url."index.php?x=atom";
$tpl = str_replace("&lt;ATOM_AUTODETECT>",$atom_url,$tpl);

and RSS:

Code:

$addon_name = "RSS2 Module";
$addon_description = "Seperated RSS generation from main index file";
$addon_version = "0.2";
// ################################################//
// RSS 2.0 FEED
// ################################################//
$url = $cfgrow['siteurl'];
$rss_url = $url."index.php?x=rss";
$tpl = str_replace("&lt;RSS_AUTODETECT>",$rss_url,$tpl);

Then using the new <RSS_AUTODETECT> tag as per the existing atom one in the head of the template file.

Note that the variable setting of $url was moved up from where it was set before in both examples.

I dunno if I'm helping here, but thought I might share in case it does help.

**raminia**+ · #2 07-20-2005, 09:06 PM

thank you

Pixelpost

Authentic Photoblog Flavour