Separation of text and script

Hello!

I am just experimenting with this script and I really find it quite flawless and positive

But as I am german, I am a little unhappy about the embedded text in the index.php, which makes it necessary to modify the script instead of using a language-file

I translated the language-file, but I had to modify the script as well

will there be a more strict separation in the future?

all the best, Connie
( I cannot show my template now, because it is too ugly for the moment)

[pixelpunk]

Connie, I'm trying to get the script output as little as possible.

In what areas (except for admin) do the script output text?
I thought I took care of most of the items, if not all.

This applies to version 1.2 btw.

// punK

Hi!

I just scrolled through index.php (version 1.2) and I have 3 major points to show:

1) text entered in the script directly, not via variable from language file

Line 333:
onChange='self.location.href=this.options[this.selectedIndex].value;'><option value=''>$lang_browse_select_category</option><option value='?x=browse&category='>All</option>";

: the word "All"

Line 390:
$tpl = ereg_replace("<COMMENT_POPUP>","<a href='#' onclick=\"window.open('index.php?popup=comment&amp ;amp;showimage=$image_id','Comments','width=480,he ight=540');\">Comments</a>",$tpl);

: the word "Comments"


2) fix dateformat, not via configuration

Line 44:
$datetime = date("Y-m-d H:i:s");

: date format

Line 227:
<br />$comment_name @ $comment_datetime

: should be variable, who likes so long dateformats in the textoutput?

Line 411:
$datetime = date("Y-m-d H:i:s");

: should be a variable date format again

3) fix integrated language file

Line 14:
require("language/lang-english.php");

: should be a variable from administration

greetings,

Connie

[pixelpunk]

Thanks for the pointers. I'll look it up for next version.

// punK